Opened on 03/16/2019 at 02:17:51 PM
Closed on 03/19/2019 at 09:46:12 AM
Last modified on 07/19/2019 at 11:37:32 AM
#7374 closed change (fixed)
Rename Snippets to snippets
| Reported by: | mjethani | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/30 |
||
Description (last modified by mjethani)
Background
See #6891 for background.
What to change
In lib/snippets.js, rename Snippets to snippets.
Integration notes
In adblockpluschrome, in lib/contentFiltering.js, rename Snippets to snippets.
Hints for testers
Just make sure that snippet filters are working as expected. Add a filter example.com#$#log Hello, go to example.com, and see that it logs Hello in the console.
Attachments (0)
Change History (6)
comment:2 Changed on 03/16/2019 at 03:04:09 PM by mjethani
- Owner set to mjethani
comment:3 Changed on 03/16/2019 at 03:04:24 PM by mjethani
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 03/18/2019 at 08:28:06 PM by abpbot
comment:5 Changed on 03/19/2019 at 09:46:12 AM by mjethani
- Description modified (diff)
- Ready set
- Resolution set to fixed
- Status changed from reviewing to closed
- Summary changed from Properly distinguish objects from classes (part 2) to Rename Snippets to snippets
comment:6 Changed on 07/19/2019 at 11:37:32 AM by ukacar
- Verified working set
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 7374 - Rename Snippets to snippets