Opened on 03/16/2019 at 10:22:12 PM
Closed on 03/19/2019 at 09:37:09 AM
Last modified on 07/25/2019 at 07:55:09 PM
#7377 closed change (fixed)
Rename Synchronizer to synchronizer
| Reported by: | mjethani | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | greiner | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/adblockpluscore/merge_requests/33 |
||
Description (last modified by mjethani)
Background
In #6891 we made the naming consistent in a few files, but somehow we forgot to lower-case exports.Synchronizer in lib/synchronizer.js.
What to change
Rename exports.Synchronizer to exports.synchronizer in lib/synchronizer.js.
Integration notes
In adblockpluschrome, in lib/subscriptionInit.js, rename Synchronizer to synchronizer.
In adblockplusui, in both background.js and messageResponder.js, rename Synchronizer to synchronizer.
Hints for testers
This change does not affect any of the code in Core, but please check the dependency update ticket in Platform for hints.
Attachments (0)
Change History (8)
comment:1 Changed on 03/16/2019 at 10:26:46 PM by mjethani
- Ready set
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/18/2019 at 08:28:07 PM by abpbot
comment:3 Changed on 03/19/2019 at 09:35:45 AM by mjethani
- Owner set to mjethani
comment:4 Changed on 03/19/2019 at 09:37:09 AM by mjethani
- Description modified (diff)
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 04/24/2019 at 04:21:00 PM by greiner
- Cc greiner added
comment:7 Changed on 07/25/2019 at 07:54:47 PM by Ross
Done. Does not look to have caused any regressions.
ABP 0.9.15.2340
Microsoft Edge 44.17763.1.0 / Windows 10 1809
ABP 3.5.2.2340
Chrome 49.0.2623.75 / Windows 10 1809
Chrome 75.0.3770.142 / Windows 10 1809
Opera 36.0.2130.65 / Windows 10 1809
Opera 62.0.3331.72 / Windows 10 1809
Firefox 51.0 / Windows 10 1809
Firefox 68.0 / Windows 10 1809
Firefox Mobile 68.0 / Android 7.2.2
comment:8 Changed on 07/25/2019 at 07:55:09 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
A commit referencing this issue has landed:
Issue 7377 - Rename Synchronizer to synchronizer