Opened on 04/02/2019 at 03:20:26 PM

Closed on 04/30/2019 at 03:07:12 PM

#7433 closed change (fixed)

Remove dependency on "specialization" attribute in subscriptions.xml

Reported by: greiner Assignee: greiner
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: Blocked By:
Blocking: #7431, #7459 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/264
​https://gitlab.com/eyeo/adblockplus/abpui/adblockpluschrome/merge_requests/26

Description

Background

We want to apply parts of the changes we made in ​ui#337 so that we don't need to include the "specialization" attribute anymore when generating the subscriptions.json file.

See discussion in #7425.

What to change

Apply changes to the following files from ​this commit:

  • data/languages.json
  • js/desktop-options.js
  • locale/en_US/desktop-options.json

Implementation notes

Import newly added data/languages.json file.

Hints for translators

Added "options_language_join" string.

Attachments (0)

Change History (4)

comment:1 Changed on 04/12/2019 at 01:10:19 PM by greiner

  • Blocking 7459 added

comment:2 Changed on 04/30/2019 at 03:05:25 PM by greiner

  • Owner set to greiner

comment:3 Changed on 04/30/2019 at 03:06:04 PM by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from greiner.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.