Context Navigation

Opened on 04/12/2019 at 02:03:23 PM

Closed on 04/16/2019 at 01:35:18 PM

#7461 closed change (fixed)

Reported by:	kvas	Assignee:	kvas
Priority:	P3	Milestone:
Module:	Sitescripts	Keywords:
Cc:	julian	Blocked By:
Blocking:		Platform:	Unknown / Cross platform
Ready:	yes	Confidential:	no
Tester:	Unknown	Verified working:	no
Review URL(s):	https://codereview.adblockplus.org/30044555/

If a website has broken links, CMS generates a warning like this:

WARNING:root:Link to some-page cannot be resolved

It's great to have a warning but it would be even better if the warning gave information on where to look for the broken links.

Include the name of the source page (the one that links to a non-existing page) into the text of the warning.

Implementation note: the link is produced by this line. We need to pass the source page into the function and insert it into the warning.

You may use WikiFormatting here.

Change Properties

Summary:
Description:	You may use WikiFormatting here. === Background === If a website has broken links, CMS generates a warning like this: {{{ WARNING:root:Link to some-page cannot be resolved }}} It's great to have a warning but it would be even better if the warning gave information on where to look for the broken links. === What to change === Include the name of the source page (the one that links to a non-existing page) into the text of the warning. Implementation note: the link is produced by [https://hg.adblockplus.org/cms/file/tip/cms/sources.py#l62 this line]. We need to pass the source page into the function and insert it into the warning.
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):	https://codereview.adblockplus.org/30044555/

Action

leave as closed .

reopen The resolution will be deleted. Next status will be 'reopened'.

reassign to The owner will be changed from kvas.

Attachments ↑ Description ↑

Note: See TracTickets for help on using tickets.