Opened on 04/17/2019 at 09:30:10 PM

Closed on 06/01/2019 at 09:59:23 PM

#7467 closed change (fixed)

Migrate rpy to Python 3

Reported by: rhowell Assignee: rhowell
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: kvas, sporz Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/30047570/

Description

Background

Python 2 will cease being supported at the start of 2020. We have decided to migrate the code to Python 3 before that date. There also seems to be an issue with string encoding when using the reticulate package in R, and migrating to Python 3 should resolve this.

What to change

Remove strings2utf8() and related tests.

Attachments (0)

Change History (3)

comment:1 Changed on 04/18/2019 at 12:16:48 AM by rhowell

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/18/2019 at 11:51:41 AM by kvas

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed on 06/01/2019 at 09:59:23 PM by rhowell

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from rhowell.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.