Opened on 04/29/2019 at 07:49:41 PM

Closed on 04/29/2019 at 07:50:41 PM

#7470 closed defect (invalid)

addFilter and addFilterText do the same thing

Reported by: erikvold Assignee: manish
Priority: Unknown Milestone:
Module: Unknown Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

This is a mistake that was introduced in #7094

​https://gitlab.com/eyeo/adblockplus/adblockpluscore/commit/80ce72582b0684d172207c8d9b61f80c446990cc

​https://gitlab.com/eyeo/adblockplus/adblockpluscore/blob/next/lib/subscriptionClasses.js#L204-218

We now have two methods addFilter and addFilterText which do exact same thing.

Attachments (0)

Change History (1)

comment:1 Changed on 04/29/2019 at 07:50:41 PM by erikvold

  • Resolution set to invalid
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from manish.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.