Opened on 05/08/2019 at 02:48:34 PM

Closed on 09/24/2019 at 07:20:03 PM

#7473 closed change (fixed)

Add fallback CSS colours to the test pages

Reported by: Ross Assignee: Ross
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: sebastian, greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/testpages.adblockplus.org/merge_requests/13

Description

Background

Some of the CSS used in the testpages does not work with some of the browsers/features used by distribution partners. For example, Opera Mini has a mode that runs through a proxy that does not support certain styles.

The problematic styles are mainly the background: repeating-linear-gradient styles.

What to change

Add fallback CSS for these features/browers.

For example:

.stripes-grey {
  border: 2px solid #bcbcbc;
  background-color: #ccc; <- Add fallback colours.
  background-image: repeating-linear-gradient(45deg, #ccc, #ccc 10px, #dbdbdb 10px, #dbdbdb 20px);
}

Attachments (0)

Change History (4)

comment:1 Changed on 05/09/2019 at 02:08:53 PM by Ross

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 06/24/2019 at 01:42:22 PM by abpbot

A commit referencing this issue has landed:
Issue 7473 - Add fallback CSS colours

comment:3 Changed on 09/24/2019 at 02:28:10 PM by greiner

  • Cc greiner added
  • Owner set to Ross

comment:4 Changed on 09/24/2019 at 07:20:03 PM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Ross.
 
Note: See TracTickets for help on using tickets.