Opened on 07/03/2014 at 05:27:56 AM
Closed on 07/03/2014 at 03:51:40 PM
Last modified on 10/15/2015 at 05:29:44 PM
#748 closed change (incomplete)
Implement blocking of inline JavaScript
| Reported by: | mikhaelkh | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Platform | Keywords: | |
| Cc: | mapx, trev, greiner, sebastian | Blocked By: | |
| Blocking: | Platform: | Chrome | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by trev)
Blocking inline JavaScript is possible in Chrome, by injecting a fake Content-Security-Policy header into the server response for particular websites. Maybe this possibility should be used in Adblock Plus.
Attachments (0)
Change History (13)
comment:1 Changed on 07/03/2014 at 05:31:21 AM by mikhaelkh
comment:2 Changed on 07/03/2014 at 08:20:52 AM by mapx
- Component changed from Unknown to Platform
- Platform changed from Unknown to Chrome
comment:3 Changed on 07/03/2014 at 08:21:34 AM by mapx
- Cc mapx added
comment:4 Changed on 07/03/2014 at 03:51:40 PM by sebastian
- Resolution set to invalid
- Status changed from new to closed
Adblock Plus already reliable blocks JavaScript. However Adblock Plus is only blocking some external scripts, and doesn't completely disable JavaScript on given pages. There are other extensions that lets you do that.
comment:5 Changed on 07/07/2014 at 09:13:42 AM by trev
- Description modified (diff)
- Summary changed from Implement new javascript blocking to Implement blocking of inline JavaScript
Note that this feature has been discussed a while ago for Firefox where it is more straightforward to implement. The problem is that blocking all inline scripts without distinguishing between them doesn't seem to be a useful feature. While it will allow getting rid of some anti-adblock messages, in 99% of the cases it will also break the website as a side-effect.
comment:6 Changed on 07/07/2014 at 09:13:56 AM by trev
- Cc trev added
comment:7 Changed on 07/07/2014 at 11:39:35 AM by mapx
something about JS injection, here:
https://issues.adblockplus.org/ticket/756
comment:8 Changed on 10/15/2015 at 11:20:26 AM by mapx
- Tester set to Unknown
comment:9 Changed on 10/15/2015 at 11:45:18 AM by trev
Not quite the same thing - he is "blocking" individual scripts (something that inevitably causes a massive performance overhead). Not that it is significantly more useful as a result, anti-adblock messages can easily be combined with required website functionality in the same <script> tag. They won't do that for a small extension like uBlock but they will definitely do it if we implement something like that.
comment:10 Changed on 10/15/2015 at 11:55:24 AM by mapx
A lot of people are using the userscripts (see anti adblock killer for example) to defeat the anti adblock tricks, so they give up on performance. Anyway the advanced users can use it to create their own filters (even if such rules wont be included by easylist). A tool which can create only specific filters.
I guess the maintenance of a site using that spaghetti sort of code is not very convenient (a contains-type selection can be refined to function level I guess)
comment:11 Changed on 10/15/2015 at 11:56:32 AM by mapx
- Cc greiner sebastian added
comment:12 Changed on 10/15/2015 at 11:58:08 AM by mapx
comment:13 Changed on 10/15/2015 at 05:29:44 PM by mario86
"Not quite the same thing". Ok. Here is a separate ticket for this: #3207
@trev: It is not true that we need this only for anti-adblock messages. Instead, some very popular German websites found a way to trick ABP and show obnoxious click-bait ads that can not be blocked with the current ABP functionality. Also performance should not be an issue, as uBlock Origin implemented this without noticeable performance impact.
I forgot to set platform to Chrome