Opened on 07/06/2014 at 04:55:10 PM
Closed on 11/10/2017 at 11:17:30 AM
#755 closed change (rejected)
EHH: show number of hidden elements
| Reported by: | famlam | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Extensions-for-Adblock-Plus | Keywords: | |
| Cc: | arthur, mapx | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | no | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
The element hiding helper should show the number of elements that will be hidden as the result of the new rule.
For example, I am on a website which contains a banner has a fully random url and can only be hidden by
site.com##img[height="120"]
To know if this filter doesn't cause any false-positives I have to check the full page if anything else does also disappear after adding that rule, which can be a lot of work on multi-column multi-section (news) websites. Or I have to assume it is correct and hope I'm not wrong.
However, it would be nice if there was a line in the EHH 'This filter hides # items on this page'.
What to change
The EHH should show a text (probably only on advanced mode), telling how many elements would be hidden on the page. This number can be obtained by calling (for example)
document.querySelectorAll("the_new_filter").length;
on the frames of the website that match the domain.
Attachments (0)
Change History (3)
comment:1 Changed on 07/07/2014 at 08:03:11 AM by arthur
- Cc arthur added
- Component changed from Unknown to Extensions-for-Adblock-Plus
comment:2 Changed on 07/07/2014 at 10:46:29 AM by mapx
- Cc mapx added
comment:3 Changed on 11/10/2017 at 11:17:30 AM by trev
- Resolution set to rejected
- Status changed from new to closed
Mass-closing all bugs in the Extensions for Adblock Plus module, these extensions no longer work as of Adblock Plus 3.0 / Firefox 57.