Opened on 07/16/2014 at 11:52:48 AM

Closed on 09/23/2014 at 08:27:34 AM

#1048 closed change (fixed)

Generate Android update manifests in the libadblockplus format

Reported by: fhd Assignee: fhd
Priority: P2 Milestone:
Module: Infrastructure Keywords:
Cc: trev Blocked By: #1049
Blocking: #98 Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by fhd)


Android update checks are still using the old format, not the one used by libadblockplus (see #98).

What to change

Generate libadblockplus update manifests for Android on

Note that we need to keep generating updates.xml and androidupdates.xml for the foreseeable future - old versions of the app will still request those.

Attachments (0)

Change History (10)

comment:1 Changed on 07/16/2014 at 11:58:08 AM by trev

  • Blocked By 44 added
  • Cc trev added

comment:2 Changed on 07/16/2014 at 03:05:34 PM by fhd

  • Blocking 98 added

comment:3 Changed on 07/16/2014 at 03:25:00 PM by fhd

  • Description modified (diff)
  • Priority changed from P3 to P2

comment:4 Changed on 07/22/2014 at 07:16:46 AM by fhd

  • Blocked By 1049 added; 44 removed
  • Description modified (diff)
  • Summary changed from Move Android updates checks to to Generate Android update manifests in the libadblockplus format

comment:5 Changed on 08/19/2014 at 03:08:21 PM by fhd

  • Owner set to fhd

comment:6 Changed on 09/12/2014 at 12:10:24 PM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed on 09/12/2014 at 01:53:24 PM by fhd

  • Review URL(s) modified (diff)

comment:8 Changed on 09/18/2014 at 03:42:49 PM by fhd

  • Review URL(s) modified (diff)

Pushed both patches, but it turns out the update.json format those generate is wrong. Here's how it looks currently:

    "minSdkVersion": "7",
    "updateURL": "",
    "revision": "318"

Here's how it needs to look to work with the libadblockplus update mechanism:

  "adblockplusandroid": {
    "url": "",
    "version": "1.2.1"

Note that we will actually be working with the version then, instead of the revision. Also note that minSdkVersion would be ignored by the libadblockplus update mechanism, so I'm not adding it.

Adding a review that addresses this.

comment:9 Changed on 09/19/2014 at 04:09:00 AM by fhd

  • Review URL(s) modified (diff)

Another review - sorry for the mess. We also need to generate devbuild update manifests in the new format.

comment:10 Changed on 09/23/2014 at 08:27:34 AM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Note: See TracTickets for help on using tickets.