Opened on 07/22/2014 at 01:15:46 PM

Closed on 01/19/2015 at 08:50:16 AM

Last modified on 02/19/2015 at 07:40:01 AM

#1099 closed change (fixed)

Move away from yoda conditions in PluginUserSettings

Reported by: oleksandr Assignee: Mailkov
Priority: P4 Milestone: Adblock-Plus-for-Internet-Explorer-1.4
Module: Adblock-Plus-for-Internet-Explorer Keywords: goodfirstbug
Cc: Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):


Change the conditions in PluginUserSettings.cpp to bo of type:
if (X != 0)
not like it is now:
if (0 != X)

Attachments (0)

Change History (9)

comment:1 Changed on 07/24/2014 at 07:51:59 AM by oleksandr

  • Keywords goodfirstbug added

comment:2 Changed on 01/08/2015 at 09:35:11 PM by Mailkov

I would like to work on this change

Last edited on 01/08/2015 at 09:40:46 PM by Mailkov

comment:3 Changed on 01/08/2015 at 09:40:12 PM by oleksandr

  • Owner set to Mailkov


comment:4 Changed on 01/08/2015 at 11:05:06 PM by Mailkov

comment:5 Changed on 01/09/2015 at 12:13:33 PM by Mailkov

I think that it's now all fixed

comment:6 Changed on 01/15/2015 at 08:35:50 AM by Mailkov

Change pull request now is
can you merge? Thank's

Last edited on 01/15/2015 at 08:43:35 AM by Mailkov

comment:7 Changed on 01/19/2015 at 08:46:24 AM by Mailkov

Can you close this issue? Thank's

comment:8 Changed on 01/19/2015 at 08:50:16 AM by oleksandr

  • Resolution set to fixed
  • Status changed from new to closed

Sure. Thank you!

comment:9 Changed on 02/19/2015 at 07:40:01 AM by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-1.4

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Mailkov.
Note: See TracTickets for help on using tickets.