Opened on 07/28/2014 at 02:23:14 PM
Closed on 12/11/2014 at 10:12:35 AM
Last modified on 12/12/2014 at 09:24:05 AM
#1158 closed change (fixed)
Clean up predefines in plugin code
| Reported by: | oleksandr | Assignee: | eric@… |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Plus-for-Internet-Explorer-1.3 |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Internet Explorer | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
Currently we have stuff like in config.h
#if (defined PRODUCT_ADBLOCKPLUS)
#define SUPPORT_FILTER
#define SUPPORT_WHITELIST
#define SUPPORT_DOM_TRAVERSER
#define SUPPORT_FRAME_CACHING
#endif
But most of those predefines are not needed, as they are always defined.
What to change
Cleanup the predefines and only use the ones that are needed.
Attachments (0)
Change History (3)
comment:1 Changed on 08/06/2014 at 08:20:43 PM by eric@adblockplus.org
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 12/11/2014 at 10:12:35 AM by oleksandr
- Ready set
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 12/12/2014 at 09:24:05 AM by fhd
- Milestone set to Adblock-Plus-for-Internet-Explorer-1.3
Note: See
TracTickets for help on using
tickets.
