Opened on 07/30/2014 at 10:28:35 AM
Last modified on 12/11/2014 at 09:54:17 AM
#1164 new change
Check WBPassThrough for exception safety
| Reported by: | sergz | Assignee: | |
|---|---|---|---|
| Priority: | P5 | Milestone: | |
| Module: | Adblock-Plus-for-Internet-Explorer | Keywords: | WBPassThrough, IE |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Internet Explorer | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
The hell of calls, especially from from different threads, in WbPassThrough looks very fragile, so to have at least something potentially harmful here looks very dangerous.
Also check that there is no non-optimal calls which can reduce the performance, undesired locks, cause any side-effects, and so on.
What to change
Currently noted that case http://codereview.adblockplus.org/5171515343503360/diff/6063544634179584/src/plugin/PluginWbPassThrough.cpp#newcode99
Attachments (0)
Note: See
TracTickets for help on using
tickets.
