Opened on 03/12/2014 at 04:43:35 PM

Closed on 11/21/2016 at 11:26:40 AM

Last modified on 08/15/2018 at 09:54:58 PM

#119 closed change (fixed)

Switch to injecting CSS for element hiding, falling back to traversal on older IE

Reported by: fhd Assignee: sergz
Priority: P3 Milestone: Adblock-Plus-for-Internet-Explorer-1.6
Module: Adblock-Plus-for-Internet-Explorer Keywords:
Cc: Blocked By: #1672, #1793
Blocking: #1642 Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by fhd)


ABP for IE currently does DOM traversal for element hiding, which has a number of issues.

What to change

We should switch to injecting CSS, which is in line with what we do on all other platforms, plus it's faster and more maintainable.

However, we need to keep using the traverser on older IE versions with limited CSS selector support. We could go over each selector, check if the IE version could support it and handle it using the traverser otherwise. That way, a considerable amount of rules could still be handled via CSS injection.

Attachments (0)

Change History (16)

comment:1 Changed on 03/12/2014 at 04:44:12 PM by philll

  • Owner set to fhd
  • Status changed from new to assigned

@fhd: Please add the required missing information and what "older IE" means exactly.

comment:2 Changed on 03/12/2014 at 10:48:28 PM by fhd

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Reporter changed from philll to fhd
  • Status changed from assigned to accepted

comment:3 Changed on 03/13/2014 at 12:58:58 AM by fhd

  • Owner fhd deleted
  • Status changed from accepted to assigned

comment:4 Changed on 03/13/2014 at 12:59:06 AM by fhd

  • Status changed from assigned to accepted

comment:5 Changed on 03/21/2014 at 09:11:02 AM by philll

  • Status changed from accepted to new

comment:6 Changed on 08/12/2014 at 12:44:33 AM by oleksandr

  • Platform set to Unknown
  • Priority changed from P3 to P4
  • Ready unset

comment:7 Changed on 08/12/2014 at 12:44:49 AM by oleksandr

  • Platform changed from Unknown to Internet Explorer

comment:8 Changed on 11/12/2014 at 04:34:12 PM by oleksandr

  • Owner set to sergz

comment:9 Changed on 12/15/2014 at 09:39:31 AM by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:10 Changed on 01/13/2015 at 03:27:15 PM by sergz

  • Blocked By 1672, 1793 added

comment:11 Changed on 01/22/2015 at 11:22:09 AM by oleksandr

  • Milestone set to Adblock-Plus-for-Internet-Explorer-Next
  • Priority changed from P4 to P3
  • Ready set

comment:12 Changed on 06/29/2015 at 01:52:15 PM by sergz

  • Blocking 1642 added

comment:14 Changed on 09/30/2016 at 03:28:45 PM by abpbot

A commit referencing this issue has landed:
Issue 119 - improve memory handling and improve code organizing

comment:15 Changed on 11/21/2016 at 11:26:40 AM by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Tester set to Unknown

comment:16 Changed on 08/15/2018 at 09:54:58 PM by abpbot

A commit referencing this issue has landed:
Fixes 119 - Updated installer links on download page

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
Note: See TracTickets for help on using tickets.