Opened on 08/22/2014 at 12:53:01 PM

Closed on 08/30/2014 at 11:04:35 AM

#1258 closed defect (fixed)

Ads in YouTube's HTML5 player aren't blocked

Reported by: sebastian Assignee: sebastian
Priority: P1 Milestone: Adblock-Plus-1.8.4-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By: #1259
Blocking: Platform: Safari
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5607308285444096

Description

How to reproduce

  1. Go to youtube.com
  2. Watch any video
  3. Make sure you got the HTML5 player (should be the default with Safari 7)

Observed behaviour

You see preroll and/or overlay ads in the video.

Expected behaviour

All ads on YouTube, including those shown with the HTML5 player, should be blocked.

Attachments (0)

Change History (5)

comment:1 Changed on 08/22/2014 at 12:53:07 PM by sebastian

The XMLHttpRequest loading those ads is blocked by EasyList. But unfortunately those requests can't be blocked on Safari. However, it is possible to block those ads, by modifying ytplayer.config.args, similar to how we rewrite falshvars.

comment:2 Changed on 08/22/2014 at 01:34:05 PM by sebastian

  • Blocked By 1259 added

comment:3 Changed on 08/22/2014 at 02:01:02 PM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 08/27/2014 at 11:30:23 AM by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Priority changed from P2 to P1

comment:5 Changed on 08/30/2014 at 11:04:35 AM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/adblockpluschrome/rev/f28fbec9ecd1

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.