#1283 closed change (fixed)

In PluginClass.cpp wrong usage of memset

Reported by:	sergz	Assignee:	sergz
Priority:	P4	Milestone:	Adblock-Plus-for-Internet-Explorer-1.3
Module:	Adblock-Plus-for-Internet-Explorer	Keywords:	goodfirstbug
Cc:	oleksandr@adblockplus.org	Blocked By:
Blocking:		Platform:	Internet Explorer
Ready:	yes	Confidential:	no
Tester:		Verified working:	no
Review URL(s):	http://codereview.adblockplus.org/6237450183639040/ http://codereview.adblockplus.org/5163581322559488/

The code is

wchar_t szClassName[MAX_PATH];
...
memset(szClassName, 0, MAX_PATH);

Apparently it nullifies only the first half of characters. it should be memset(szClassName, 0, MAX_PATH * sizeof(wchar_t));

replace all memset calls by std::array::fill to clear the arrays and change the variable type
check all usages of sizeof. Replace sizeof(TYPE_NAME) by sizeof(variable) except for the allocation case. It's safer to use the latter variant.
replace zero initialization via ZeroMemory and memset by SomeType var = {}. It is list initialization which falls back on value initialization which initializes the everything to zero if there is no default constructor. We cannot use value initialization right now because it's not supported by c++ compiler from MSVS2012.

Summary:
Description:	You may use WikiFormatting here. === Background === The code is {{{ wchar_t szClassName[MAX_PATH]; ... memset(szClassName, 0, MAX_PATH); }}} Apparently it nullifies only the first half of characters. it should be `memset(szClassName, 0, MAX_PATH * sizeof(wchar_t));` === What to change === - replace all `memset` calls by `std::array::fill` to clear the arrays and change the variable type - check all usages of `sizeof`. Replace `sizeof(TYPE_NAME)` by `sizeof(variable)` except for the allocation case. It's safer to use the latter variant. - replace zero initialization via ZeroMemory and memset by `SomeType var = {}`. It is [http://en.cppreference.com/w/cpp/language/list_initialization list initialization] which falls back on [http://en.cppreference.com/w/cpp/language/value_initialization value initialization] which initializes the everything to zero if there is no default constructor. We cannot use value initialization right now because it's not supported by c++ compiler from MSVS2012.
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):	http://codereview.adblockplus.org/6237450183639040/ http://codereview.adblockplus.org/5163581322559488/