Opened on 09/02/2014 at 06:20:56 AM

Last modified on 12/21/2017 at 11:29:03 AM

#1298 new change

AppInfo should be passed into FilterEngine, not JsEngine

Reported by: fhd Assignee:
Priority: P4 Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

Description (last modified by fhd)

Background

We're currently passing the AppInfo object to JsEngine, which does nothing but make it available as a global object. Since the object is highly Adblock Plus specific, we should pass it to FilterEngine instead.

What to change

Pass the AppInfo object to FilterEngine instead of JsEngine.

While we're at it - it probably shouldn't be optional.

Attachments (0)

Change History (2)

comment:1 Changed on 09/02/2014 at 06:24:36 AM by fhd

  • Description modified (diff)

comment:2 Changed on 12/21/2017 at 11:29:03 AM by fhd

  • Cc trev removed

Add Comment

Modify Ticket

Change Properties
Action
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none).
Next status will be 'reviewing'.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.