Remove the DEBUB_BLOCKER and other DEBUG macroses

[oleksandr]

Background

Currently we have a lot of DEBUB_BLOCKER, DEBUG_HIDE etc macroses throughout the code. They are mostly broken, and don't act as they should.

What to change

Change all the instances of DEBUB_BLOCKER, DEBUG_PARSER, DEBUG_HIDE etc to respective counter part from CPluginDebug

[Mailkov]

I would like to work on this change.

[oleksandr]

Here you go!

[oleksandr]

Did we miss a pull request here? What's the status here?

[Mailkov]

Hi,
This week I have not been good, so I could not, as my intention to devote to this issue.

However, looking at it now, I do not find instances of DEBUG_BLOCKER ...

Can You show me code of an instance of DEBUG_BLOCKER ? ... So I can quickly close this issue.

[Mailkov]

On file Config.h

there are this line:

#define DEBUG_FUNC CPluginDebug::Debug
#define DEBUG_ERROR_FUNC CPluginDebug::DebugError
#define DEBUG_ERROR_CODE_FUNC CPluginDebug::DebugErrorCode

#if (defined ENABLE_DEBUG_INFO && defined ENABLE_DEBUG_GENERAL)
#undef  DEBUG_GENERAL
#define DEBUG_GENERAL(x) DEBUG_FUNC(x);
#endif

#if (defined ENABLE_DEBUG_INFO)
#undef  DEBUG
#define DEBUG(x) DEBUG_FUNC(x);
#endif

#if (defined ENABLE_DEBUG_INFO && defined ENABLE_DEBUG_BLOCKER)
#undef  DEBUG_BLOCKER
#define DEBUG_BLOCKER(x) DEBUG_FUNC(x);
#endif

#if (defined ENABLE_DEBUG_INFO && defined ENABLE_DEBUG_FILTER)
#undef  DEBUG_FILTER
#define DEBUG_FILTER(x) DEBUG_FUNC(x);
#endif

The DEBUG_BLOCKER(x) is defined as DEBUG_FUNC(x) and DEBUG_FUNC is defined as CPluginDebug::Debug

So DEBUG_BLOCKER is already a CPluginDebug macrose , so I don't know what to do, can You help me ?

Thanks

[oleksandr]

We would like to move away from these macros. So wherever there is a DEBUG_BLOCKER there should be CPluginDebug::Debug directly instead. All the unused macros would be deleted then.

[Mailkov]

Pull request: ​https://github.com/adblockplus/adblockplusie/pull/9

[oleksandr]

See the discussion about this issue here: ​http://codereview.adblockplus.org/5747779603267584/#msg6

[Mailkov]

I read the discussion, I think I have done what You had asked for this issue ...
I'm not really cranky ... :) because I love to program, so there is no problem if you want reject my pull request.
Tell me what you want me to do. I'll do it.

[oleksandr]

The pull request has been rejected. Please let us know if you'd like to work on some non 'goodfirstbug' issue though ;)