Opened on 09/11/2014 at 05:55:44 PM

Closed on 09/18/2014 at 07:06:28 PM

#1362 closed change (fixed)

createNightlies script should call ensure_dependencies

Reported by: trev Assignee: trev
Priority: P4 Milestone:
Module: Infrastructure Keywords:
Cc: Blocked By: #170, #1361
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/6627397512200192/

Description

Background

See #170, we've implemented our custom dependencies mechanism and the development build creation needs to expect that the extensions actually use it.

What to change

When createNightlies.py clones the extension directory, it should run ensure_dependencies on it. Since it uses its own buildtools copy it should disable self-update and make sure buildtools dependency isn't being pulled. It also needs to override roots setting.

Attachments (0)

Change History (3)

comment:1 Changed on 09/11/2014 at 05:56:12 PM by trev

  • Blocked By 1361 added

comment:2 Changed on 09/11/2014 at 06:19:41 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 09/18/2014 at 07:06:28 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/sitescripts/rev/76cae46d043b

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.