Opened on 09/26/2014 at 12:43:16 PM
Closed on 10/10/2014 at 06:29:52 PM
#1449 closed change (fixed)
Prefer Mercurial over Git
| Reported by: | matze | Assignee: | AAlvz |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Automation | Keywords: | infrastructure hg git |
| Cc: | fhd, trev, poz2k4444, AAlvz, mathias@adblockplus.org | Blocked By: | |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): |
http://codereview.adblockplus.org/5025466448609280 |
||
Description
The ensure_dependencies.py script currently maintains all known repository types as a Python dict. This implies that the iteration order is defined by the hashing algorithm used - which currently causes git(1) being preferred over hg(1) when both are used in parallel.
We should introduce a convention that defines our priorities and thus which SCM to prefer (irregardless whether we want to change the current behavior or not, we should just control that ourselves in the first place) and actually promote Mercurial as primary choice in the script.
Attachments (0)
Change History (5)
comment:1 Changed on 09/26/2014 at 12:43:48 PM by matze
- Cc mathias@adblockplus.org added
- Component changed from Unknown to Build-and-Release-Tools
- Owner set to AAlvz
- Priority changed from Unknown to P4
- Review URL(s) modified (diff)
comment:2 Changed on 09/26/2014 at 12:46:29 PM by matze
comment:3 Changed on 09/30/2014 at 04:49:45 PM by matze
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 10/10/2014 at 11:44:17 AM by matze
@trev @fhd
Please make sure the changes are pushed to the buildtools repo.
@AAlvz
As soon as the buildtools repo has been updated this ticket can be closed.
comment:5 Changed on 10/10/2014 at 06:29:52 PM by trev
- Ready set
- Resolution set to fixed
- Status changed from reviewing to closed
FYI: In the review-URLs of this ticket I've just linked a patch/commit we've created that should do the trick. We will, however, use this ticket to introduce @AAlvz to the upload.py script and codereview.adblockplus.org..