Opened on 10/30/2014 at 04:17:42 AM

Closed on 10/31/2014 at 05:03:50 AM

#1515 closed change (fixed)

Mention dynamic properties in the Filter and Subscription docs

Reported by: fhd Assignee: fhd
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/4978935175577600/

Description

Background

We do not supply accessors for most properties in Filter and Subscription objects. We should document this.

What to change

Mention the dynamic properties in the docs for Filter and Subscription and point to the respective field summary in the jsdoc.

Attachments (0)

Change History (3)

comment:1 Changed on 10/30/2014 at 04:20:13 AM by fhd

  • Owner set to fhd

comment:2 Changed on 10/30/2014 at 04:20:28 AM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 10/31/2014 at 05:03:50 AM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

Pushed: ​https://hg.adblockplus.org/libadblockplus/rev/f30859fb16e3

And deployed: ​https://adblockplus.org/docs/libadblockplus/index.html

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.