Opened on 11/07/2014 at 01:40:49 PM
Closed on 11/27/2014 at 03:29:20 PM
#1552 closed change (fixed)
Add v8::Isolate::Scope member into JsContext
| Reported by: | sergz | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Libadblockplus | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #1197 | Platform: | Unknown |
| Ready: | no | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by sergz)
Background
It sets current isolate and v8 stuff into thread local storage. Since we use it from different threads, it's required for the proper work
Without v8::Isolate::Scope current isolate is nullptr.
Callstack of crash
> tests.exe!v8::internal::Isolate::Current() Line 489 C++ tests.exe!v8::TryCatch::TryCatch() Line 1912 C++ tests.exe!AdblockPlus::JsValue::Call(const std::vector<std::shared_ptr<AdblockPlus::JsValue>,std::allocator<std::shared_ptr<AdblockPlus::JsValue> > > & params, std::shared_ptr<AdblockPlus::JsValue> thisPtr) Line 226 C++ tests.exe!`anonymous namespace'::ReadThread::Run() Line 81 C++ tests.exe!`anonymous namespace'::CallRun(AdblockPlus::Thread * thread) Line 31 C++ kernel32.dll!@BaseThreadInitThunk@12() Unknown ntdll.dll!__RtlUserThreadStart() Unknown ntdll.dll!__RtlUserThreadStart@8() Unknown
Attachments (0)
Change History (3)
comment:1 Changed on 11/10/2014 at 09:33:51 AM by sergz
- Blocking 1197 added
- Cc 1197 removed
- Description modified (diff)
comment:2 Changed on 11/10/2014 at 09:46:54 AM by sergz
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 11/27/2014 at 03:29:20 PM by sergz
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
