Opened on 12/16/2014 at 08:49:31 AM
Closed on 12/18/2014 at 02:08:51 PM
Last modified on 03/25/2015 at 03:02:35 PM
#1704 closed change (fixed)
Don't configure content scripts with "match_about_blank" on Chrome
Reported by: | sebastian | Assignee: | sebastian |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Automation | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #1703 | Platform: | Unknown |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
Description (last modified by sebastian)
Background
With comment:5:ticket:581 we began using the match_about_blank option for content scripts.
That option were introduced in Chrome 37. However, on Chrome 37-40 content scripts using this option don't run at document_start on javascript: URLs (Chrome Bug 416907). Moreover, the load event isn't dispatched for content scripts running on about:blank or javascript: URLs (Chrome bug 442107).
Therefore we cannot use the match_about_blank for now, and have to apply element hiding and collapsing from the parent document of those frames again, as done by #1703.
What to change
Remove the match_about_blank option for content scripts on Chrome.
https://hg.adblockplus.org/buildtools/rev/cec64f71eca0