Opened on 01/08/2015 at 03:11:16 PM
Closed on 01/08/2015 at 03:44:53 PM
Last modified on 05/20/2015 at 02:22:39 PM
#1765 closed change (fixed)
Align Firefox messaging implementation with Safari
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-2.6.7-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description (last modified by trev)
Background
Abstraction layer for messaging was introduced to Firefox in #1706. The implementation was very similar to Safari's, yet some of the changes introduced in #1724 made the two implementation diverge (with good reason).
What to change
Implement the relevant changes in Firefox as well:
- If there is no response, don't set the payload property of the message instead of sending responseSent: false.
- Use a local sent variable instead of the this._responseSent property to save whether the message was handled.
- Return a list with results from all handlers in EventTarget._dispatch instead of making assumptions about the nature of the result.
Hints for testers
This change again affects all functionality of the first-run page.
Attachments (0)
Change History (4)
comment:1 Changed on 01/08/2015 at 03:14:50 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 01/08/2015 at 03:44:53 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 01/08/2015 at 04:30:47 PM by trev
- Description modified (diff)
- Milestone set to Adblock-Plus-for-Firefox-next
comment:4 Changed on 05/20/2015 at 02:22:39 PM by philll
- Platform changed from Firefox/Firefox Mobile to Firefox
Made Firefox and Firefox mobile available as seperate platforms.
Note: See
TracTickets for help on using
tickets.
Fixed: https://hg.adblockplus.org/adblockplus/rev/2d1a9ce36e0a