Opened on 01/10/2015 at 12:00:19 AM

Closed on 01/10/2015 at 08:35:47 AM

#1772 closed change (fixed)

[JSHydra] Convert const to var for Chrome

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: Blocked By:
Blocking: #145 Platform: Chrome
Ready: no Confidential: no
Tester: Verified working:
Review URL(s):

​http://codereview.adblockplus.org/4935066966818816/

Description

Background

#145 introduced a bunch of module using "use strict". Testing these modules fails in Chrome right now because const variables are left unchanged - yet Chrome no longer allows them in "strict" JavaScript.

What to change

Convert const variables to regular ones using in JSHydra.

Attachments (0)

Change History (2)

comment:1 Changed on 01/10/2015 at 12:03:57 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/10/2015 at 08:35:47 AM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/jshydra/rev/4032ca1eaecc

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.