Opened on 01/15/2015 at 12:49:08 PM

Closed on 01/15/2015 at 06:27:19 PM

Last modified on 05/20/2015 at 02:22:39 PM

#1813 closed change (fixed)

Implement ext.showOptions() in Firefox

Reported by: trev Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.6.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By: #1814
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

http://codereview.adblockplus.org/5817039037923328/

Description

Background

This is a spinoff from #1663: the first-run page currently has to call different code to open options depending on whether it is running in Firefox or Chrome. It should always call ext.showOptions() instead.

What to change

Implement ext.showOptions() in Firefox.

Attachments (0)

Change History (5)

comment:1 Changed on 01/15/2015 at 12:51:04 PM by trev

  • Blocked By 1814 added

comment:2 Changed on 01/15/2015 at 01:02:47 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 01/15/2015 at 06:27:19 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 03/10/2015 at 01:54:23 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next

comment:5 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.