#1834 closed change (worksforme)

Add public domain suffix import to buildtools

Mozilla maintain a list of public domain suffixes online. We use this in our extensions, but we store it in a different format.

Currently keeping our copies of the list up to date is a manual process and this is time consuming. Hence our list is outdated most of the time.

Implement .build.py -t chrome getpublicsuffixlist. This command should:

Description modified (diff)
Priority changed from Unknown to P3
Ready set
Summary changed from Add public domain suffix import feature to buildtools to Add public domain suffix import to buildtools

It's build.py -t chrome updatepsl actually.

Interesting, didn't know that. Do you think we should update the public suffix list during the release process, just like we do for translations?

Yes, that probably makes sense.

Note that there is a second copy of it in the libadblockplus repository, we probably want to keep it in sync.

Summary:
Description:	You may use WikiFormatting here. === Background === Mozilla maintain [https://publicsuffix.org/list/effective_tld_names.dat a list of public domain suffixes online]. We use this in our extensions, but we store it in a different format. Currently keeping our copies of the list up to date is a manual process and this is time consuming. Hence our list is outdated most of the time. === What to change === Implement `.build.py -t chrome getpublicsuffixlist`. This command should: 1. Download [https://publicsuffix.org/list/ Mozilla's Public Suffix List] 2. Convert it to the [https://github.com/adblockplus/adblockpluschrome/blob/master/lib/publicSuffixList.js format used internally] by Adblock Plus 3. Update `lib/publicSuffixList.js`
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):