Opened on 02/12/2015 at 02:59:32 PM
Closed on 02/13/2015 at 06:21:06 PM
#1992 closed defect (fixed)
createNightlies.py incorrectly determines repository name if repository path ends with a slash
Reported by: | trev | Assignee: | trev |
---|---|---|---|
Priority: | P1 | Milestone: | |
Module: | Infrastructure | Keywords: | |
Cc: | fhd | Blocked By: | |
Blocking: | Platform: | Unknown | |
Ready: | yes | Confidential: | no |
Tester: | Verified working: | ||
Review URL(s): |
Description (last modified by trev)
How to reproduce
- Configure the Android repository with a trailing slash:
abpandroid_repository=/foo/bar/adblockplusandroid/ abpandroid_type=android abpandroid_name=Adblock Plus for Android abpandroid_downloadPage=/en/android
- Run python -m sitescripts.extensions.bin.createNightlies. Alternatively, run the following Python code:
import sitescripts.extensions.utils as utils for config in utils.Configuration.getRepositoryConfigurations(): print [config.repository, config.basename]
Observed behaviour
Android builds are placed into the development builds root directory. The Python code prints (among other things):
['/foo/bar/adblockplusandroid', '']
This only affects repositories where the repository name cannot be determined from metadata and has to be guessed from repository path.
Expected behaviour
Android builds should be placed in the adblockplusandroid subdirectory. The Python code should print:
['/foo/bar/adblockplusandroid', 'adblockplusandroid']
Attachments (0)
Change History (3)
Note: See
TracTickets for help on using
tickets.
Fixed: https://hg.adblockplus.org/sitescripts/rev/c9ad526408c4