Opened on 03/11/2014 at 10:34:14 AM

Closed on 06/05/2014 at 07:05:32 AM

#20 closed change (fixed)

[libadblockplus integration cleanup] Don't use std::bind for UpdateAvailableCallback, it's redundant

Reported by: fhd Assignee:
Priority: P3 Milestone: Adblock-Plus-for-Android-1.3
Module: Adblock-Plus-for-Android Keywords:
Cc: Blocked By:
Blocking: #7 Platform:
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

Description

Background

See #7.

What to change

Don't use std::bind for UpdateAvailableCallback, it's redundant (​http://codereview.adblockplus.org/11172036/diff/1/jni/abpEngine.cpp#newcode166)

Attachments (0)

Change History (12)

comment:1 Changed on 03/11/2014 at 10:51:58 AM by philll

  • Blocking 7 added

comment:2 Changed on 03/11/2014 at 12:57:59 PM by philll

  • Keywords libadblockplus integration cleanup removed

comment:3 Changed on 03/11/2014 at 09:34:51 PM by trev

  • Component changed from Unknown to ABP-Android

comment:4 Changed on 03/12/2014 at 11:38:19 AM by philll

  • Owner set to rjeschke
  • Status changed from new to assigned

comment:5 Changed on 03/12/2014 at 04:55:19 PM by fhd

  • Priority changed from Unknown to P3

comment:6 Changed on 03/12/2014 at 05:09:03 PM by fhd

  • Reporter changed from philll to fhd

comment:7 Changed on 03/12/2014 at 05:12:33 PM by fhd

  • Owner rjeschke deleted

comment:8 Changed on 03/12/2014 at 05:12:56 PM by fhd

  • Status changed from assigned to accepted

comment:9 Changed on 03/21/2014 at 09:11:02 AM by philll

  • Status changed from accepted to new

comment:10 Changed on 06/02/2014 at 09:20:11 AM by rjeschke

  • Ready unset
  • Resolution set to invalid
  • Status changed from new to closed

comment:11 Changed on 06/05/2014 at 07:05:11 AM by fhd

  • Resolution invalid deleted
  • Status changed from closed to reopened

comment:12 Changed on 06/05/2014 at 07:05:32 AM by fhd

  • Milestone set to Adblock-Plus-for-Android-next
  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed by #16.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.