Opened on 02/26/2015 at 12:27:54 PM
Closed on 02/27/2015 at 10:35:12 AM
Last modified on 05/20/2015 at 02:22:39 PM
#2047 closed change (fixed)
Update QUnit to version 1.17.1
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-2.6.8-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #2040, #2048 | Platform: | Firefox |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | ||
| Review URL(s): | |||
Description (last modified by sebastian)
Background
Currently Adblock Plus uses QUnit 1.12 to run its tests. This is a very old version however. Also start() and stop() have been deprecated. But the new method to write asynchronous tests isn't available in QUnit 1.12. So we should update QUnit before writing any more asynchronous test code (like for #2040), to reduce the amount of code that needs to be adapted later (by #2048).
What to change
Update QUnit as used to test Adblock Plus to version 1.17.1.
Hints for testers
The test suite isn't part of the build. So there is nothing to test here.
Attachments (0)
Change History (8)
comment:1 Changed on 02/26/2015 at 12:28:58 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 02/26/2015 at 12:36:25 PM by sebastian
- Blocking 2048 added
comment:6 Changed on 02/26/2015 at 02:21:03 PM by trev
- Component changed from Core to Adblock-Plus-for-Firefox
- Platform changed from Unknown to Firefox/Firefox Mobile
- Review URL(s) modified (diff)
comment:7 Changed on 02/27/2015 at 10:35:12 AM by sebastian
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 05/20/2015 at 02:22:39 PM by philll
- Platform changed from Firefox/Firefox Mobile to Firefox
Made Firefox and Firefox mobile available as seperate platforms.
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockplustests/rev/1dfc91631dfd