Add a pre-configurable option to disable the first run page in Firefox

[treed873]

Background

Is there a way to disable the first run tab from opening for new users in a domain? I have set up adblock plus to self install on a thin client system, where the C drive is static. Bottom line is, when a user logs in, they are basically a new user every time. Therefore they will receive the "Adblock Plus has been installed" page every time they log in.

What to change

Add a preference to skip the first run page.

[mapx]

feature requested too by few chrome users

[greiner]

Currently, it is not implemented but we could introduce ​a setting for that which we'd check in the function that opens the first-run page and prevent it from being opened.

[treed873]

That would be a welcomed addition.

As a temporary workaround/hack, I simply removed this section of code from ui.js:

function notifyUser()
    {
      let {addTab} = require("appSupport");
      if (addTab)
      {
        addTab(window, "chrome://adblockplus/content/ui/firstRun.html");
      }
      else
      {
        let dialogSource = '\
          <?xml-stylesheet href="chrome://global/skin/" type="text/css"?>\
          <dialog xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" onload="document.title=content.document.title" buttons="accept" width="500" height="600">\
            <iframe type="content-primary" flex="1" src="chrome://adblockplus/content/ui/firstRun.html"/>\
          </dialog>';
        Services.ww.openWindow(window,
                               "data:application/vnd.mozilla.xul+xml," + encodeURIComponent(dialogSource),
                               "_blank", "chrome,centerscreen,resizable,dialog=no", null);
      }

This seems to work well in our environment.

[Gingerbread Man]

I simply removed this section of code from ui.js:

That requires either not updating Adblock Plus, or redoing the changes every time. You should be able to accomplish the same thing without modifying Adblock Plus by locking the extensions.adblockplus.currentVersion preference.
​http://kb.mozillazine.org/Locking_preferences

extensions.adblockplus.currentVersion
Stores the last used Adblock Plus version, this will trigger actions that need to be done on upgrade or first install

[treed873]

I have the Preferences locked in my mozilla.cfg file:

// disable application updates
pref("app.update.enabled", false)

It will still show the first run tab every time. There really isn't an option that I can see that will enable me to disable this.

[fhd]

IMO this is a pretty platform-specific issue, so I'm changing the component for this to Firefox again.

I've filed #278 about implementing this in Chrome.

[Gingerbread Man]

pref("app.update.enabled", false)

1. That preference isn't locked.
2. What does disabling Firefox updates have to do with this issue? I'm saying try adding the following to mozilla.cfg:

   lockPref("extensions.adblockplus.currentVersion", "2.5.1");
   

[treed873]

Yes, I see what you mean about disabling Firefox updates, but I really don't see how disabling ABP from updating will fix this either. Because of my environment (see above), ABP sees every login as a new user, therefore it will always bring up the Welcome tab.

[fhd]

I'll add a pref for this.

[fhd]

Pushed: ​https://hg.adblockplus.org/adblockplus/rev/2f20ef5ff7df
And documented: ​https://adblockplus.org/en/preferences

[sebastian]

You added just a regular preference, not a pre-configurable one as specified in the issue description. The description is outdated anyway. And eventually what you did might be sufficient. But please update the description to reflect the actual change.

[fhd]

​It is preconfigurable, that's also why I removed #1489 from Blocked by. There's a discussion, in #1489 among other places, about a mechanism for preconfiguring preferences while still allowing the user to change prefs, but that's a separate thing IMO.

But you're right, the description said it should be a pre-configurable option as implemented by #1489, which is not what happened. Changed it.

[fhd]

Was pushed as: ​https://hg.adblockplus.org/adblockplus/rev/2f20ef5ff7df