Opened on 03/12/2015 at 02:57:34 PM

Closed on 03/24/2015 at 02:35:21 PM

#2131 closed change (fixed)

Non existing job redirection on [eyeo.com]

Reported by: saroyanm Assignee: sebastian
Priority: Unknown Milestone:
Module: Infrastructure Keywords:
Cc: sebastian Blocked By: #662
Blocking: Platform: Unknown
Ready: no Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5727102489853952

Description (last modified by saroyanm)

Background

In #662 we are changing the way the jobs page is implement, we are going to create separate page for each job, but we also need to consider the case when user navigates to no more existing job page.

What to change

Use en/job/not-available.html as custom 404 page for /en/job/* URLs.

Attachments (0)

Change History (6)

comment:1 follow-up: Changed on 03/12/2015 at 05:03:04 PM by sebastian

IMO, no redirect should happen here. Instead en/job/not-available.html should be used as custom 404 page for /en/job/* URLs.

comment:2 Changed on 03/12/2015 at 05:03:18 PM by sebastian

  • Cc sebastian added

comment:3 in reply to: ↑ 1 Changed on 03/12/2015 at 05:09:26 PM by saroyanm

  • Description modified (diff)

Replying to sebastian:

IMO, no redirect should happen here. Instead en/job/not-available.html should be used as custom 404 page for /en/job/* URLs.

Good point, description updated.

comment:4 Changed on 03/24/2015 at 11:05:39 AM by sebastian

  • Owner set to sebastian

comment:5 Changed on 03/24/2015 at 11:06:53 AM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 03/24/2015 at 02:35:21 PM by sebastian

  • Resolution set to fixed
  • Status changed from reviewing to closed
  • Verified working unset

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
 
Note: See TracTickets for help on using tickets.