Opened on 03/13/2015 at 04:03:08 PM

Last modified on 03/16/2015 at 11:19:43 AM

#2141 new change

Clean up: initializing of s_mimeFilter in CPluginClass::OnBeforeNavigate2

Reported by: sergz Assignee:
Priority: P4 Milestone:
Module: Adblock-Plus-for-Internet-Explorer Keywords: goodfirstbug
Cc: sergz, oleksandr Blocked By:
Blocking: Platform: Internet Explorer
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

Description

Background

  • we don't need s_mimeFilter = CPluginClientFactory::GetMimeFilterClientInstance(); in OnBeforeNavigate2 because it's always registered in SetSite
  • it's even not protected

What to change

Just remove it.

Attachments (0)

Change History (2)

comment:1 Changed on 03/16/2015 at 11:19:04 AM by oleksandr

  • Cc sergz oleksandr added
  • Platform changed from Unknown to Internet Explorer
  • Priority changed from Unknown to P4
  • Ready set

It is there in case for some reason registering the mime filter didn't happen before the navigation. I would leave it just in case. However it does get called now: when blocking is disabled everywhere and a user is navigating to a webpage. This probably needs to be fixed so that it wouldn't register mime filter if it doesn't need to.

comment:2 Changed on 03/16/2015 at 11:19:43 AM by oleksandr

  • Keywords goodfirstbug added

Add Comment

Modify Ticket

Change Properties
Action
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none).
Next status will be 'reviewing'.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.