Opened on 03/17/2015 at 08:50:48 AM

Closed on 03/17/2015 at 02:17:28 PM

#2154 closed change (fixed)

Improve ENC by removing hiera/private requirement

Reported by: matze Assignee: matze
Priority: P3 Milestone:
Module: Infrastructure Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

​http://codereview.adblockplus.org/6269682487132160/

Description

The External Node Classifier and Hiera (see #112) could be improved by removing the requirement for the new hiera/private directory and instead declaring modules/private/hiera as the canonical path for private hiera configuration.

What to change

  • Ensure hiera/hiera.yaml reflects the canonical path and improve the :hierarchy: accordingly
  • Update both the hiera/install_precise.py and the hiera/puppet_node_classifier.rb script to feature the new canonical path
  • Remove or replace the related documentation in README.md
  • Anything that may be necessary but has been forgotten here :)

Attachments (0)

Change History (2)

comment:1 Changed on 03/17/2015 at 02:13:11 PM by matze

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 03/17/2015 at 02:17:28 PM by matze

  • Resolution set to fixed
  • Status changed from reviewing to closed

Pushed after ​LGTM in review: ​https://hg.adblockplus.org/infrastructure/rev/611de9022686
Fixed a bug found while testing: ​https://hg.adblockplus.org/infrastructure/rev/1fe1454047d2

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from matze.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.