Opened on 03/19/2015 at 09:50:43 PM

Closed on 03/20/2015 at 06:23:27 PM

#2180 closed change (fixed)

[cms] Add support for custom Jinja2 functions

Reported by: trev Assignee: trev
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working:
Review URL(s):

​http://codereview.adblockplus.org/5521995252891648/

Description

Background

Currently, we can only define custom filters in the content repository. This leads to weird semantics however, e.g. get_subscription being a filter rather than a function.

What to change

Add a way to define custom functions in the same way custom filters are defined. Functions should be placed under functions/function_name.py and export a function function_name.

Attachments (0)

Change History (3)

comment:1 Changed on 03/19/2015 at 09:53:04 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 03/20/2015 at 04:10:33 PM by trev

  • Blocking 662 removed

Given that #2179 took a different route, this is no longer a requirement for #662.

comment:3 Changed on 03/20/2015 at 06:23:27 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/cms/rev/98479aeb3079

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.