Opened on 03/20/2015 at 05:41:34 PM
Closed on 06/29/2015 at 01:19:52 PM
Last modified on 07/24/2015 at 04:32:20 AM
#2193 closed change (fixed)
Add notification opt-out to Firefox
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.6.10-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | saroyanm, sven | Blocked By: | #2192 |
| Blocking: | #2191, #2726 | Platform: | Firefox |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | no |
| Review URL(s): | |||
Description (last modified by trev)
Background
In #2192 we added opt-out capabilities for notifications and we need to expose those in the extension UI.
What to change
Notification:
- Add an "x" in the top-right corner of the notification.
- Upon clicking the "x", the notification content should be replaced with the following two links (see screenshot):
- Close this notification: Hide the notification
- Stop showing notifications: Hide the notification and add "*" to Prefs.notifications_ignoredcategories
The following options should be hidden by default and only be shown if Prefs.notifications_showui is set to true:
Options menu:
- Add a menu item "Show useful notifications" to icon context menu's "Options" submenu. Note that this menu is also used within the browser menu bar (see screenshot).
- Clicking on this item should toggle the "*" entry in Prefs.notifications_ignoredcategories.
Preferences page:
- Add a checkbox "Show useful notifications" to preferences page at "about:addons".
- This checkbox should toggle the "*" entry in Prefs.notifications_ignoredcategories.
Attachments (2)
Change History (13)
Changed on 03/20/2015 at 05:50:39 PM by greiner
Changed on 03/20/2015 at 05:51:08 PM by greiner
comment:2 Changed on 03/20/2015 at 07:03:27 PM by greiner
- Blocked By 2192 added
- Description modified (diff)
comment:3 Changed on 03/26/2015 at 03:26:49 PM by saroyanm
- Cc saroyanm added
- Verified working unset
comment:4 Changed on 03/27/2015 at 04:21:12 PM by greiner
- Owner set to greiner
- Summary changed from Add UI for opting-out of notifications to Firefox to Add notification opt-out to Firefox
comment:8 Changed on 04/14/2015 at 03:24:01 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:9 Changed on 06/26/2015 at 09:32:03 AM by greiner
- Blocking 2726 added
comment:10 Changed on 06/29/2015 at 01:19:52 PM by greiner
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:11 Changed on 07/24/2015 at 04:32:20 AM by Ross
- Platform changed from Unknown to Firefox
- Tester set to Ross
Add an "x" in the top-right corner of the notification.
Done / Working.
Upon clicking the "x", the notification content should be replaced with the following two links (see screenshot):
Close this notification: Hide the notification
Stop showing notifications: Hide the notification and add "*" to Prefs.notifications_ignoredcategories
Done / Working.
The following options should be hidden by default and only be shown if Prefs.notifications_showui is set to true
Done / Working.
Add a menu item "Show useful notifications" to icon context menu's "Options" submenu. Clicking on this item should toggle the "*" entry in Prefs.notifications_ignoredcategories.
Done / Working.
Add a checkbox "Show useful notifications" to preferences page at "about:addons". This checkbox should toggle the "*" entry in Prefs.notifications_ignoredcategories.
Done / Working.
Tested with:
ABP 2.6.9.3966 / Firefox 39.0 / Windows 7 x64
(Note: I attempted to test on OS X, however Firefox in OS X in a VM is currently affected by this bug (https://bugzilla.mozilla.org/show_bug.cgi?id=1180688) and nightlies are e10s, which also does not work in VM for me at the moment.)
Updated texts to make them shorter and more accurate following a discussion with Sven.