Opened on 04/04/2015 at 11:24:29 PM

Closed on 05/22/2015 at 01:03:20 PM

Last modified on 06/30/2015 at 12:34:11 PM

#2274 closed change (fixed)

[Send notifications to a subset of the user base] Move notification parsing into a module

Reported by: fhd Assignee: fhd
Priority: P2 Milestone:
Module: Sitescripts Keywords:
Cc: Blocked By:
Blocking: #2162, #2275 Platform: Unknown
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

​http://codereview.adblockplus.org/6308119894294528/

Description

Background

For #2162, we need to parse notifications in a handler. Currently this is happening in a management script, so we need to move it into a module. We need to keep the management script around for some time so we can roll out #2162 gradually.

What to change

Move notification parsing from generateNotifications.py to a new module.

Attachments (0)

Change History (6)

comment:1 Changed on 04/04/2015 at 11:26:55 PM by fhd

  • Blocking 2275 added

comment:2 Changed on 04/04/2015 at 11:37:26 PM by fhd

  • Summary changed from Move notification parsing into a module to [Send notifications to a subset of the user base] Move notification parsing into a module

comment:3 Changed on 04/04/2015 at 11:38:31 PM by fhd

  • Owner set to fhd

comment:4 Changed on 04/04/2015 at 11:38:45 PM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 05/22/2015 at 01:03:20 PM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

Pushed: ​https://hg.adblockplus.org/sitescripts/rev/ceb07b9cf96e

comment:6 Changed on 06/30/2015 at 12:34:11 PM by Ross

  • Tester set to Ross
  • Verified working set

This has been implemented/done.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.