Opened on 04/10/2015 at 10:23:36 AM

Closed on 04/13/2015 at 12:39:47 PM

#2297 closed change (fixed)

Call chrome.webRequst.behaviorChanged() only for request filter changes

Reported by: sebastian Assignee: sebastian
Priority: P4 Milestone: Adblock-Plus-1.9-for-Chrome-Opera-Safari
Module: Platform Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/4938965924708352

Description

Background

Currently chrome.webRequst.behaviorChanged() is called on every filter change. However, only request blocking/whitelisting filters have an effext on the webRequest handler behavior. Hence this expeensive function is potentially called more often than required.

What to change

Don't call chrome.webRequst.behaviorChanged() when other filters than request blocking/whitelisting filters have been added/removed.

Attachments (0)

Change History (3)

comment:1 Changed on 04/10/2015 at 10:24:31 AM by sebastian

  • Summary changed from Call chrome.webRequst.behaviorChanged() only for request filters to Call chrome.webRequst.behaviorChanged() only for request filter changes

comment:2 Changed on 04/10/2015 at 10:24:53 AM by sebastian

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 04/13/2015 at 12:39:47 PM by sebastian

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

​https://hg.adblockplus.org/adblockpluschrome/rev/40892833ef4d

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sebastian.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.