Opened on 04/10/2015 at 12:58:15 PM

Closed on 04/30/2015 at 12:30:06 PM

Last modified on 05/07/2015 at 11:59:40 AM

#2299 closed change (fixed)

Create a filter list repository for ads injected by adware

Reported by: arthur Assignee: fhd
Priority: P3 Milestone:
Module: Infrastructure Keywords:
Cc: trev, matze, till Blocked By:
Blocking: Platform: Unknown
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/4799232384958464/

Description

Background

According to Till we want to block ads injected by adware extension in the future. I need a filter list repository to create that list.

What to change

  • Create a repository on hg.adblockplus.org called "adwarefilters"
  • Add "adwarefilters" to filtermaster configuration
  • Give me access for it
  • The repository shouldn't be listed on hg.adblockplus.org for now

Attachments (0)

Change History (7)

comment:1 Changed on 04/10/2015 at 01:01:04 PM by arthur

Wladimir, I'm not sure if that's really confidential or not. We should be aware that the repository name will be visible in the infrastructure repository once it's added to the filtermaster config and the list itself will be visible later in the filter lists stats as well.

Last edited on 04/10/2015 at 01:02:09 PM by arthur

comment:2 Changed on 04/10/2015 at 01:11:05 PM by arthur

  • Cc till added

comment:3 Changed on 04/29/2015 at 07:36:58 AM by fhd

  • Owner set to fhd
  • Priority changed from Unknown to P3
  • Ready set
  • Sensitive unset

Don't see why this should be confidential, unsetting.

I've created the adwarefilters repository, will prepare a patch for adding that to the filtermaster next.

Arthur is the only one with commit access - you'll have to do the initial commit.

comment:4 Changed on 04/29/2015 at 08:40:21 AM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Review is up, however, I can't test/push this before the initial commit has happened.

comment:5 Changed on 04/30/2015 at 10:23:44 AM by arthur

comment:6 Changed on 04/30/2015 at 12:30:06 PM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed on 04/30/2015 at 12:57:30 PM by fhd

OK, pushed (https://hg.adblockplus.org/infrastructure/rev/9c5704715ff7) and deployed, should be live in about 5 minutes.

Last edited on 05/07/2015 at 11:59:40 AM by fhd

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
 
Note: See TracTickets for help on using tickets.