Opened on 04/17/2015 at 09:16:02 AM
Closed on 05/20/2015 at 09:29:55 AM
Last modified on 05/21/2015 at 03:23:10 PM
#2335 closed change (fixed)
Create landing page for successful email verification
| Reported by: | saroyanm | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | sebastian, sven, annlee@adblockplus.org, lisabielik | Blocked By: | |
| Blocking: | #2213, #2234, #2436 | Platform: | Unknown |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): |
http://codereview.adblockplus.org/6216724063977472/ |
||
Description (last modified by sebastian)
Background
In #2213 we are creating landing page for Adblock Browser for Android beta launch, but we also should have subscription field on that page where users can subscribe for being notified about Adblock Plus IOS browser launch. Users will get confirmation email (#2234) after subscription. So we need also a landing page where we can redirect users to that have verified their email address.
What to change
Add successful verification page:
Url -> https://adblockplus.org/en/adblock-browser/verification-success
Text -> Thanks for your submission! We'll email you before the launch.
Add meta tag bellow to the head section of both pages:
<meta name="robots" content="noindex">
Attachments (0)
Change History (18)
comment:2 Changed on 04/17/2015 at 09:32:50 AM by saroyanm
- Description modified (diff)
- Priority changed from Unknown to P2
- Ready set
comment:3 Changed on 04/17/2015 at 09:47:41 AM by saroyanm
- Cc sven added
comment:5 follow-up: ↓ 6 Changed on 04/17/2015 at 11:41:28 AM by sebastian
- Cc annlee@adblockplus.org lisabielik added; annlee@… removed
The texts are semantically correct, but I suppose Ann-Lee or Lisa could still improve the phrasing.
comment:6 in reply to: ↑ 5 Changed on 04/17/2015 at 11:50:09 AM by saroyanm
Replying to sebastian:
The texts are semantically correct, but I suppose Ann-Lee or Lisa could still improve the phrasing.
Please note that text is already improved by Lisa. But, sure if there will be more improvements then we can go with new text. Anyway current text looks to be good enough to give a go I think.
comment:7 Changed on 04/17/2015 at 11:51:18 AM by sebastian
Ah ok, didn't realize. Then it should be fine.
comment:8 Changed on 04/24/2015 at 11:51:29 AM by sebastian
- Description modified (diff)
- Summary changed from Two verification landing pages on adblockplus.org to Create landing page for successful email verification
I've updated the issue, since as discussed with saroyanm and specified in #2234, there will only be a one landing page for successful email verification.
comment:9 Changed on 04/27/2015 at 02:17:02 PM by sebastian
- Blocking 2234 added
comment:10 Changed on 04/29/2015 at 12:22:55 PM by saroyanm
- Owner set to saroyanm
- Review URL(s) modified (diff)
comment:11 Changed on 04/29/2015 at 12:23:06 PM by saroyanm
- Status changed from new to reviewing
comment:12 Changed on 04/29/2015 at 01:29:59 PM by saroyanm
I'll close the issue when the actually page will be created, I do not want to create it now, to be 100% free from leak while the path that mentioned in the ticket is sub directory of adblock-browser.
comment:13 Changed on 04/29/2015 at 01:55:07 PM by saroyanm
- Blocking 2436 added
comment:14 follow-up: ↓ 15 Changed on 05/11/2015 at 07:22:03 PM by Ross
I still need an exported .xml of this page or access to the patch/change on Google code to test this one.
comment:15 in reply to: ↑ 14 Changed on 05/11/2015 at 07:28:08 PM by saroyanm
Replying to Ross:
I still need an exported .xml of this page or access to the patch/change on Google code to test this one.
Please check initial mail with the attachment, the XML should be available there.
comment:16 Changed on 05/18/2015 at 06:28:48 PM by saroyanm
- Review URL(s) modified (diff)
comment:17 Changed on 05/20/2015 at 09:29:55 AM by saroyanm
- Resolution set to fixed
- Review URL(s) modified (diff)
- Status changed from reviewing to closed
comment:18 Changed on 05/21/2015 at 03:23:10 PM by saroyanm
- Sensitive unset
@Sven please let me know if you would like to have some special design of showing that notification, otherwise I'll go with default heading.