Opened on 04/18/2015 at 08:38:54 PM
Closed on 05/04/2015 at 05:23:33 PM
Last modified on 01/27/2016 at 03:42:44 PM
#2346 closed change (fixed)
[Adblocking settings] Add the adblocking languages category
| Reported by: | fhd | Assignee: | rjeschke |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-beta-1.0.0.2015052021 |
| Module: | Adblock-Browser-for-Android | Keywords: | 2015q2 |
| Cc: | Blocked By: | ||
| Blocking: | #2345 | Platform: | Adblock Browser for Android |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by philll)
Background
See #2345.
What to change
Add a new settings category where the user can add/remove adblocking languages, as in the mockup.
These languages are actually not languages, but language-specific filter subscriptions - those are the subscriptions from subscriptions2.xml that have the prefixes attribute. The text from the specialization attribute should be shown as the language's name (e.g. German in the mockup), and the text from the title attribute below that (e.g. EasyList in the mockup).
The category should have two sections:
Active for websites in ..., which should show all the language-specific filter subscriptions that are currently enabled.
Other languages, which should show all the language-specific filter subscriptions that are not added or disabled.
When the user toggles the switch next to a subscription, the subscription should move to the other section. Activating a subscription should add (or, if already present, enable) it, deactivating a subscription should remove it.
Attachments (1)
Change History (17)
comment:1 Changed on 04/18/2015 at 08:39:36 PM by fhd
- Owner set to rjeschke
comment:2 Changed on 04/18/2015 at 08:40:20 PM by fhd
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 04/20/2015 at 10:35:48 AM by fhd
- Ready unset
Changed on 04/28/2015 at 10:52:51 AM by fhd
Adblocking settings mock up
comment:4 Changed on 04/28/2015 at 11:03:25 AM by fhd
- Description modified (diff)
- Ready set
Specified things properly (I guess), setting to Ready again.
comment:5 Changed on 04/29/2015 at 09:22:58 AM by philll
- Ready unset
Which lists and respective languages shall be shown in general? Please provide that list explicitly with links to the respective lists. Not showing the list's names at all might confuse more advanced users.
The language names of active choices in the mockup are lower case, which is wrong.
What are "spezialisation texts from subscriptions.xml" and where to find them?
What does "enable the subscription for that language" mean?
The summary "Adblocking languages" is just a caption if at all, but not a summary. Also, as mentioned before, not having any hint on the target location of a change in the summary maked it incredibly hard to use lists of issues in Trac.
comment:6 Changed on 04/29/2015 at 12:20:37 PM by fhd
- Description modified (diff)
- Summary changed from [Adblocking settings] Adblocking languages to [Adblocking settings] Add the adblocking languages category
The texts are all taken from subscriptions.xml - how that works is so obvious to me that I didn't even think about explaining it, but you're right, has to be explained. Is that clear now?
comment:7 Changed on 04/29/2015 at 12:24:08 PM by fhd
- Description modified (diff)
The patch under review is actually already showing the subscription names - all the better.
comment:8 Changed on 04/30/2015 at 11:32:04 AM by fhd
- Description modified (diff)
Trying to reduce the confusion between languages/subscriptions a bit.
comment:9 Changed on 04/30/2015 at 01:02:34 PM by fhd
- Ready set
comment:10 Changed on 05/04/2015 at 05:23:33 PM by rjeschke
- Resolution set to fixed
- Status changed from reviewing to closed
comment:11 Changed on 05/06/2015 at 07:29:24 AM by fhd
- Milestone set to Flux-next
comment:12 Changed on 05/06/2015 at 05:03:08 PM by fhd
- Keywords 2015q2 added
comment:13 Changed on 05/20/2015 at 09:00:48 AM by fhd
- Sensitive unset
comment:14 Changed on 05/22/2015 at 09:32:34 PM by fhd
comment:15 Changed on 06/30/2015 at 09:33:59 AM by philll
- Platform changed from Android to Adblock Browser for Android
See #2673
comment:16 Changed on 01/27/2016 at 03:42:44 PM by philll
- Description modified (diff)
- Tester set to Unknown
Removing ready - this is not specified properly.