Integrate CSS property rule handling in Chrome/Opera/Safari

[trev]

Background

We are working on adding support for CSS property filters #2388, which will allow elements to be hidden when matching CSS style rules are applied to them.

Adding support for this has required multiple changes, mostly to the adblockplus and adblockplusui repositories. We now want to bring these changes into our Adblock Plus for Chrome by updating those dependencies and integrating the code.

What to change

• Update the adblockplusui dependency to include the messageResponder.js changes in #2396. Specifically to revision 223229de6599 (and in Git 261b5d3). This will include three other commits:
  • ​Issue 2381 - Added share overlay to options page (see required changes)
  • ​Issue 2410 - Improved accessibility of dialogs in options page
  • ​Issue 2018 - Optimized first-run page for smaller screens

• Update the adblockplus dependency to include the changes in #2392, #2393 and #2395. Specifically to revision c0345d415b32 (and in Git 245e0d7). This will include several other commits, but none with relevant changes.
• Update the adblockplustests dependency to include the changes in #2394. Specifically to revision 2fa49573d6c1 (and in Git 8343d6e). This will include several other commits but none that are relevant to the Chrome extension. (There are a few changes to Firefox related files and metadata for es10 support and an added README.)
• Integrate the code into include.preload.js, starting from this diff ​https://pastebin.mozilla.org/8850328
• Make the required changes to metadata.common to include cssProperties.js and cssRules.js

What to test

• That the extension continues to function properly on Chrome, Opera and Safari.
• That all the tests pass, including the new CSS property filter ones.
• That ​property filters work on Dave's test page for Chrome, Opera and Safari. (Test both with the block element tool, refreshing the page and adding the rules manually.)

[kzar]

(This issue's description isn't ready as it stands. I'm going to try and update it after reading the surrounding issues, but any help would with that would likely save time and be appreciated.)

[kzar]

With help from Thomas we made some progress with this today, I successfully hid a element using a simple CSS property filter on ​my test page.

I've found a few small changes to be made to the code in reviews for #2392, #2393 and #2395 but it seems to be more or less working. I'm now looking to see how I can test things more thoroughly.

If you'd like to reproduce my environment to work on your issues or test things you can check out my branch ​https://github.com/kzar/adblockpluschrome/tree/2388-css-filters in GitHub. (I've updated the dependencies file, so building should use the 2388-css-filters branch for adblockplus and adblockplusui as well.)

[greiner]

Moved the testing-related part of the ticket description to the What to test section and linked to the dependecy update notes in #2381 instead of duplicating them here.

[kzar]

​https://hg.adblockplus.org/adblockplus/rev/c0345d415b32

[kzar]

​https://hg.adblockplus.org/adblockpluschrome/rev/42abd43aeb83