Opened on 05/03/2015 at 11:59:46 PM
Closed on 11/10/2017 at 11:15:18 AM
#2447 closed defect (rejected)
Clicking on abp: links doesn't work in SeaMonkey
| Reported by: | barbaz | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | trev, greiner | Blocked By: | |
| Blocking: | Platform: | SeaMonkey | |
| Ready: | no | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by greiner)
[see http://forums.mozillazine.org/viewtopic.php?f=40&t=2932139 ]
Environment
Adblock Plus 2.6.9.3933
SeaMonkey 2.33.1
How to reproduce
new profile
1) Install Adblock Plus
2) Restart SeaMonkey
3) Navigate to https://adblockplus.org/en/features#socialmedia
4) Click "open this dialogue"
Observed behaviour
Got a message from the browser saying that the abp: protocol isn't recognized.
This is apparently because Adblock Plus does not call window.getBrowser() to retrieve browser in SeaMonkey.
With the modification suggested in http://forums.mozillazine.org/viewtopic.php?p=14141987#p14141987 , this appears to work as expected.
Expected behaviour
Adblock Plus should have offered to add Fanboy's Social Blocking List subscription.
What to change
In lib/appSupport.js the SeaMonkey-specific getBrowser method should call and return the value of window.getBrowser() if window.gBrowser is null.
Attachments (0)
Change History (4)
comment:1 Changed on 05/04/2015 at 07:21:42 AM by mapx
- Cc trev greiner added
comment:2 Changed on 05/06/2015 at 01:35:26 PM by greiner
- Component changed from Unknown to Adblock-Plus-for-Firefox
- Description modified (diff)
comment:3 Changed on 09/21/2017 at 01:47:55 AM by sebastian
- Platform changed from Unknown to SeaMonkey
comment:4 Changed on 11/10/2017 at 11:15:18 AM by trev
- Resolution set to rejected
- Status changed from new to closed
Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.
I was able to reproduce this issue.