Opened on 05/06/2015 at 01:56:45 PM

Closed on 05/06/2015 at 09:30:35 PM

Last modified on 06/30/2015 at 09:33:59 AM

#2464 closed change (fixed)

Add language part to the top sites links

Reported by: fhd Assignee: fhd
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015052021
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5092578215067648/

Description (last modified by fhd)

Background

We're currently linking to acceptableads.org and adblockplus.org in our top sites. These sites, however, do a redirect based on the user's language, so they end up on adblockplus.org/en/ for example - a different site. Consequently, this shows up as a separate top site.

What to change

Change the top sites links from:

adblockplus.org to adblockplus.org/en/

and:

acceptableads.org to acceptableads.org/en/

The link is stored in a translation file anyway, so we can have a different link for each language. That's not brilliant, but good enough for now.

Attachments (0)

Change History (10)

comment:1 Changed on 05/06/2015 at 04:56:49 PM by fhd

  • Description modified (diff)
  • Summary changed from Hard code language in the top site links to Localise adblockplus.org and acceptableads.org link

comment:2 Changed on 05/06/2015 at 04:57:37 PM by fhd

  • Owner set to fhd

comment:3 Changed on 05/06/2015 at 08:24:55 PM by fhd

  • Description modified (diff)

comment:4 Changed on 05/06/2015 at 08:26:37 PM by fhd

  • Description modified (diff)
  • Summary changed from Localise adblockplus.org and acceptableads.org link to Add language part to the top sites links

comment:5 Changed on 05/06/2015 at 08:41:43 PM by fhd

  • Description modified (diff)

comment:6 Changed on 05/06/2015 at 08:46:25 PM by fhd

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed on 05/06/2015 at 09:30:35 PM by fhd

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed on 05/20/2015 at 09:00:48 AM by fhd

  • Sensitive unset

comment:9 Changed on 05/26/2015 at 03:04:06 PM by fhd

Was pushed as: ​https://bitbucket.org/adblockplus/adblockbrowser/commits/c3fc5c5ea69d

comment:10 Changed on 06/30/2015 at 09:33:59 AM by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from fhd.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.