Opened on 04/02/2014 at 01:32:13 PM
Closed on 05/09/2014 at 11:20:23 AM
#247 closed defect (fixed)
Bad blocking rule suggestion
| Reported by: | arthur | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-2.6.1-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | smultron45@gmail.com, famlam | Blocked By: | |
| Blocking: | Platform: | ||
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Environment
Windows 8.1 Pro x64
Firefox 28
Adblock Plus 2.5.1.3788
How to reproduce
- Go to http://query.nytimes.com/search/sitesearch/#/obama/since1851/allresults/1/allauthors/newest/
- Try to block this resource:
http://www.google.com/uds/afs?q=obama&client=newyorktimes-cse&adsafe=high&adpage=0&r=s&oe=UTF-8&ie=UTF-8&fexp=21404&format=n7&ad=n0&nocache=1701396445032500&num=0&output=uds_ads_only&v=3&adext=as1%2Csr1&rurl=http%3A%2F%2Fquery.nytimes.com%2Fsearch%2Fsitesearch%2F%23%2Fobama%2Fsince1851%2Fallresults%2F1%2Fallauthors%2Fnewest%2F#slave-1-1
Observed behaviour
The given suggestion for a rule is the following:
google.com/uds/afs#slave-1-1?*
If you doubleclick it, it changes into
|google.com/uds/afs#slave-1-1?*
Expected behaviour
The suggested filter should be as follows:
||google.com/uds/afs?q=obama&client=newyorktimes-cse&adsafe=high&adpage=0&r=s&oe=UTF-8&ie=UTF-8&fexp=21404&format=n7&ad=n0&nocache=1701396445032500&num=0&output=uds_ads_only&v=3&adext=as1%2Csr1&rurl=http%3A%2F%2Fquery.nytimes.com%2Fsearch%2Fsitesearch%2F%23%2Fobama%2Fsince1851%2Fallresults%2F1%2Fallauthors%2Fnewest%2F#slave-1-1
Forum topic
Attachments (0)
Change History (6)
comment:1 Changed on 04/02/2014 at 01:38:25 PM by arthur
- Ready set
comment:2 Changed on 04/02/2014 at 02:05:24 PM by mapx
- Cc smultron45@gmail.com added
comment:3 Changed on 04/04/2014 at 12:56:11 PM by philll
- Cc famlam added
comment:4 Changed on 05/09/2014 at 06:53:24 AM by trev
- Owner set to trev
- Priority changed from Unknown to P2
comment:5 Changed on 05/09/2014 at 06:59:05 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 05/09/2014 at 11:20:23 AM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Yes, looks like we don't clear the hash part of the URLs - we definitely should.