Opened on 05/07/2015 at 09:02:40 PM

Closed on 05/07/2015 at 09:17:47 PM

Last modified on 06/30/2015 at 09:33:59 AM

#2473 closed defect (fixed)

Interaction with ABP doesn't work

Reported by: fhd Assignee: rjeschke
Priority: P1 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015052021
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/5391942804307968/

Description

Environment

Adblock Browser revision 08d7790aed21 on Android 5.0.2 on a Nexus 9.

How to reproduce

There are multiple bugs caused by the underlying issue, but here is one that's particularly quick to reproduce:

  1. Go to any remote website, e.g. https://adblockplus.org
  2. Open the hamburger menu

Observed behaviour

The Block Ads on this Site menu item is disabled.

Expected behaviour

The Block Ads on this Site menu item should be enabled - it's only supposed to be disabled for local sites.

Managing subscriptions or enabling/disabling Acceptable Ads in the settings page doesn't work either - the communication between app and extension is obviously not working anymore.

Attachments (0)

Change History (7)

comment:1 Changed on 05/07/2015 at 09:03:06 PM by fhd

  • Owner set to rjeschke

comment:2 Changed on 05/07/2015 at 09:03:57 PM by fhd

This is a regression introduced by #2352.

comment:3 Changed on 05/07/2015 at 09:10:16 PM by rjeschke

  • Platform changed from Unknown to Android
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 05/07/2015 at 09:17:47 PM by rjeschke

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 05/20/2015 at 09:00:48 AM by fhd

  • Sensitive unset

comment:6 Changed on 05/22/2015 at 09:31:25 PM by fhd

comment:7 Changed on 06/30/2015 at 09:33:59 AM by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from rjeschke.
 
Note: See TracTickets for help on using tickets.