Opened on 05/08/2015 at 09:48:31 AM

Closed on 05/08/2015 at 04:30:00 PM

Last modified on 06/30/2015 at 09:33:59 AM

#2480 closed defect (fixed)

Synced tabs item is showing up on the new tab page

Reported by: fhd Assignee: rjeschke
Priority: P2 Milestone: Adblock-Browser-for-Android-beta-1.0.0.2015052021
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5146556827172864/

Description

Environment

Adblock Browser for Android revision 989a6e356d4a on a Nexus 9 running Android 5.0.2.

How to reproduce

  1. Open the new tab page (by clicking on the plus icon)

Observed behaviour

There's an item called SYNCED TABS, next to RECENT TABS.

Expected behaviour

There shouldn't be an item called SYNCED TABS on the new tab page, since we've disabled the feature (#2417).

Attachments (0)

Change History (8)

comment:1 Changed on 05/08/2015 at 09:48:43 AM by fhd

  • Milestone set to Flux-next

comment:2 Changed on 05/08/2015 at 09:50:22 AM by fhd

Pretty sure this is a regression introduced by our upstream merge (#2352).

comment:3 Changed on 05/08/2015 at 03:59:28 PM by rjeschke

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 05/08/2015 at 04:18:26 PM by rjeschke

  • Owner set to rjeschke

comment:5 Changed on 05/08/2015 at 04:30:00 PM by rjeschke

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 05/20/2015 at 09:00:48 AM by fhd

  • Sensitive unset

comment:7 Changed on 05/26/2015 at 03:21:28 PM by fhd

Was pushed as: ​https://bitbucket.org/adblockplus/adblockbrowser/commits/95a8edf02e58

comment:8 Changed on 06/30/2015 at 09:33:59 AM by philll

  • Platform changed from Android to Adblock Browser for Android

See #2673

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from rjeschke.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.