Opened on 05/18/2015 at 07:59:19 PM

Closed on 05/18/2015 at 08:26:54 PM

Last modified on 05/20/2015 at 02:22:39 PM

#2550 closed defect (fixed)

Update Element Hiding Helper dependency on buildtools to revision 9069f8de837b

Reported by: trev Assignee: trev
Priority: P4 Milestone: Element-Hiding-Helper-1.3.3
Module: Extensions-for-Adblock-Plus Keywords:
Cc: Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/6368645210963968/

Description

Background

Element Hiding Helper is currently on a buildtools revision from January, it should be updated.

What to change

  • Update dependency to revision 9069f8de837b
  • Re-run ensure_dependencies.py (for self-update)
  • Rename defaults/prefs.js into defaults/prefs.json and change format (#2444).

While there has been a number of other buildtools changes, none seem to affect Element Hiding Helper build.

Attachments (0)

Change History (3)

comment:1 Changed on 05/18/2015 at 08:03:00 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 05/18/2015 at 08:26:54 PM by trev

  • Milestone set to Element-Hiding-Helper-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/elemhidehelper/rev/593b34eb4c02

comment:3 Changed on 05/20/2015 at 02:22:39 PM by philll

  • Platform changed from Firefox/Firefox Mobile to Firefox

Made Firefox and Firefox mobile available as seperate platforms.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.