Opened on 05/28/2015 at 01:36:00 PM
Closed on 08/08/2017 at 11:44:58 AM
Last modified on 09/14/2017 at 01:52:17 PM
#2606 closed defect (fixed)
Firefox logo shown in background on empty Adblock Browser New Tab and Search pages
| Reported by: | greiner | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Browser-for-Android-1.2.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29341383/ |
||
Description
Environment
Adblock Browser 1.0.0.20150522163354
Settings under Customize / Home / Panels:
- Recent Tabs: hidden
- History: hidden
- Top Sites: hidden
- Bookmarks: hidden
- Reading List: hidden
How to reproduce
- Apply the settings as listed above
- Open a new tab
Observed behavior
Firefox logo shown in background (see screenshot)
Expected behavior
Adblock Browser logo shown in background
Attachments (2)
Change History (18)
Changed on 05/28/2015 at 01:36:18 PM by greiner
comment:1 Changed on 06/30/2015 at 09:33:59 AM by philll
- Platform changed from Unknown to Adblock Browser for Android
comment:2 Changed on 08/28/2015 at 12:17:31 PM by Ross
- Tester set to Ross
The Firefox logo is also visible if you:
- Put the Adblock Browser search widget on the home screen.
- Tap/focus the widget to start a search.
- If you have no searches yet/they are cleared, a Firefox logo is visible (attached).
Changed on 08/28/2015 at 12:18:59 PM by Ross
comment:3 Changed on 08/28/2015 at 12:19:26 PM by Ross
- Summary changed from Firefox logo shown in background on empty Adblock Browser New Tab page to Firefox logo shown in background on empty Adblock Browser New Tab and Search pages
comment:4 Changed on 05/13/2016 at 09:57:01 AM by diegocarloslima
- Owner set to diegocarloslima
comment:5 Changed on 05/13/2016 at 10:28:48 AM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 09/15/2016 at 02:09:01 PM by diegocarloslima
- Ready set
comment:7 Changed on 11/21/2016 at 01:10:19 PM by abpbot
A commit referencing this issue has landed:
Issue 2606 - Firefox logo shown in background on empty Adblock Browser New Tab and Search pages
comment:8 Changed on 11/21/2016 at 01:12:34 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed on 06/19/2017 at 08:05:00 AM by scheer
- Resolution fixed deleted
- Status changed from closed to reopened
- Tester changed from Ross to Scheer
The Firefox Logo is correctly removed from the following screens:
Recent Tabs: hidden
History: hidden
Top Sites: hidden
Bookmarks: hidden
Reading List: hidden
The Firefox Logo is still present with the following screen:
- Put the Adblock Browser search widget on the home screen.
- Tap/focus the widget to start a search.
- If you have no searches yet/they are cleared, a Firefox logo is visible (attached).
ABB adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0
comment:10 Changed on 06/20/2017 at 10:18:14 AM by greiner
As a sidenote I'd also like to point out that a full-color logo is used whereas the Firefox one was monochromatic which means that it draws more attention to it and appears more like it can be interacted with than the Firefox one.
comment:11 Changed on 07/04/2017 at 07:58:16 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from reopened to reviewing
comment:12 Changed on 07/17/2017 at 11:55:12 PM by abpbot
A commit referencing this issue has landed:
Issue 2606 - Firefox logo shown in background on empty Adblock Browser New Tab and Search pages
comment:13 Changed on 08/08/2017 at 11:44:58 AM by diegocarloslima
- Resolution set to fixed
- Status changed from reviewing to closed
comment:14 Changed on 08/10/2017 at 05:05:39 AM by rscott
- Tester changed from Scheer to Unknown
- Verified working set
LGTM
comment:15 Changed on 09/14/2017 at 01:31:26 PM by abpbot
A commit referencing this issue has landed:
Issue 2606 - Firefox logo shown in background on empty Adblock Browser New Tab and Search pages
comment:16 Changed on 09/14/2017 at 01:52:17 PM by abpbot
A commit referencing this issue has landed:
Issue 2606 - Merge fix
See #2673