Opened on 06/19/2015 at 01:21:09 PM
Closed on 07/10/2015 at 02:50:58 PM
#2697 closed defect (invalid)
[ABP for FF] - [Filter pref.] "Restore backup" function doesn't seem to work
| Reported by: | passbrains | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | greiner | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by Shikitita)
Adapted from https://www.passbrains.com/dashboard/view-ticket.php?ticket_no=ARE-118
Environment
Windows + 8 64bit + Firefox + Russian
ABP version 2.6.9.3930
How to reproduce
1) Download Mozilla 37.0.1
2) Download ABP.
3) Click ABP icon.
4) Click filter's setings.
5) Click "backup and restore".
6) Click "restore copy".
Observed behaviour
There is error message.
Expected behaviour
There is not error message.
Attachments (3)
Change History (13)
Changed on 06/19/2015 at 01:21:13 PM by passbrains
Changed on 06/19/2015 at 01:21:14 PM by passbrains
comment:1 Changed on 06/19/2015 at 01:21:16 PM by passbrains
comment:2 Changed on 06/19/2015 at 02:51:43 PM by Shikitita
- Description modified (diff)
- Summary changed from Problem with restore backup. to [Adblock Plus] - [Firefox] - [Filter preferences] "Restore backup" function doesn't seem to work
comment:3 Changed on 06/22/2015 at 09:36:37 AM by Shikitita
- Summary changed from [Adblock Plus] - [Firefox] - [Filter preferences] "Restore backup" function doesn't seem to work to [ABP for FF] - [Filter pref.] "Restore backup" function doesn't seem to work
comment:4 Changed on 06/22/2015 at 05:18:44 PM by greiner
- Cc greiner added
- Component changed from Unknown to Adblock-Plus-for-Firefox
I couldn't reproduce this on my machine so could you please attach the corrupted backup file to this ticket?
Changed on 06/24/2015 at 07:46:31 AM by Shikitita
Automatic backup file
comment:5 follow-up: ↓ 6 Changed on 06/24/2015 at 08:22:20 AM by Shikitita
The file above is the file generated automatically by ABP as soon as the software is installed, as per the Steps to Reproduce in this issue. However, its size is less than 1MB and with no information to restore, for which reason the following error message pops up on the screen: "The file's data could not be processed, maybe this isn't an Adblock Plus backup file?".
comment:6 in reply to: ↑ 5 Changed on 06/24/2015 at 09:45:05 AM by greiner
- Resolution set to invalid
- Status changed from new to closed
Replying to Shikitita:
The file above is the file generated automatically by ABP as soon as the software is installed, as per the Steps to Reproduce in this issue. However, its size is less than 1MB and with no information to restore, for which reason the following error message pops up on the screen: "The file's data could not be processed, maybe this isn't an Adblock Plus backup file?".
The file format appears to be ok but the provided file is empty i.e. doesn't contain any filters or filter lists. Therefore I'd consider this issue invalid since the restore functionality appears to be working as intendend.
comment:7 follow-up: ↓ 8 Changed on 06/24/2015 at 04:38:14 PM by philll
- Resolution invalid deleted
- Status changed from closed to reopened
Wow - setting this issue to invalid simply because the describes symptoms aren't the bug itself seems very wrong to me. We should find the underlying issue and fix this accordingly.
comment:8 in reply to: ↑ 7 Changed on 06/24/2015 at 04:46:23 PM by greiner
Replying to philll:
Wow - setting this issue to invalid simply because the describes symptoms aren't the bug itself seems very wrong to me. We should find the underlying issue and fix this accordingly.
The issue mentioned in here is invalid. The issue that led to the creation of that empty backup file is independent of this issue especially since the ticket doesn't even mention where that file comes from.
Therefore I'd rather tackle this in a separate ticket instead of completely rewriting the entire ticket.
comment:9 Changed on 06/25/2015 at 12:09:34 PM by philll
@greiner: I'm fine with that (Although not really seeing the big advantage), so please provide that new issue and then feel free to invalidate this here, after having linked to the new one.
comment:10 Changed on 07/10/2015 at 02:50:58 PM by greiner
- Resolution set to invalid
- Status changed from reopened to closed
- Tester set to Unknown
Created a new ticket at #2768. Since I cannot reproduce it myself, I just reused the instructions from this ticket but leaving out the parts about restoring the backup.
1 - 19 Jun 2015 13:20:54 posted by Tamara Blasco
Please note that the file ABP is trying to restore appears to lack information in order for the software to be able to execute it.